Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alert/detection colors as background for motion segments #11182

Merged
merged 1 commit into from
May 1, 2024

Conversation

hawkeye217
Copy link
Collaborator

  • Remove side alert/detection bars on motion timeline
  • Use dimmed alert/detection color as background color for motion segments with alerts/detections
  • Remove dimming of motion segments for reviewed/unreviewed
  • Adjusted as agreed by Blake and other maintainers

Copy link

netlify bot commented May 1, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit fb4e5dc
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/66318ced2f9a990008d9f791
😎 Deploy Preview https://deploy-preview-11182--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit bb33563 into dev May 1, 2024
13 checks passed
@NickM-27 NickM-27 deleted the motion-timeline-adjustments branch May 1, 2024 00:38
@T3chArmy
Copy link

T3chArmy commented May 1, 2024

@hawkeye217 Just out of curiosity, was this intentionally left off the review pages for Alerts and Detections?

I see it on the motion tab of the review page, and also see it if I click into the history for a camera from the live view.

I feel the colored timeline background provides a much cleaner experience.

@hawkeye217
Copy link
Collaborator Author

Yes. We decided to move away from something our UI designer originally designed - the small bar on the right hand side of the motion review timeline.

The other maintainers and I decided on this to highlight what motion segments were associated with an alert or a detection.

The alerts and detections pages don't need a background color as there's already a bar down the middle of the timeline to indicate when there was an alert or detection.

@T3chArmy
Copy link

T3chArmy commented May 2, 2024

Thanks for taking the time to respond! I just wanted to make sure this was intentional, and not something that may have gotten overlooked! Appreciate your contributions to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants