Force X axis labels to be rotated correctly #11148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
|
I would prefer not do this as the more ticks gives more context when there is room. I would suggest setting rotation to 0 (or maybe it is 90?) in the config so they are always horizontal and then perhaps they will just ellipsis. Otherwise we may want to think about using a resizeObserver and dynamically adjusting the number of tick marks |
This reverts commit 941e296.
|
Easy, text isn't even cutoff |
xconverge
changed the title
NickM-27
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of ways to fix this but it seemed simplest to me...open to whatever you all want
Before the change sometimes I would get tilted X axis labels to fit and it would mess up the entire layout
We could adjust paddings, we could adjust label formats, or we could just do this for now and not special case it