Reuse open connection, fix #920

[fl42]

Hello,

This PR it's an attempt to fix #920
What is your opinion on the fix?

As the problem appears randomly, I don't know if this fix totally solves it.

EDIT: it runs for few days without any issue of my side

[blakeblackshear]

I think the proper fix is described here. This issue started after adding gevent to handle websockets.

[fl42]

I'm not a big fan of monkeypatching the thread module but...I agree that sharing connections between threads is not the best option too

I'm considering rewriting the WS part (or event the full API) using FastAPI
Would you accept such a big refactoring @blakeblackshear?

[blakeblackshear]

I don't know much about fastapi, but yes. I am not sure how it will impact the other parts of frigate given you must start it with uvicorn.

[fl42]

Ok I'll try on my side

[b3nj1]

FWIW, I this PR also fixed the issue on my side. Further, it seems to have reduced the load on the server by something like 50-60%!!
Is there a reason that it's not safe to re-use the connection as in this PR?

• Benjamin

[blakeblackshear]

I'm not sure why it would change the server load. I plan to address this in a different way for the next release.

[fl42]

@blakeblackshear Would you consider merging this fix with a patch release bump? (before the proper fix in 0.9.0)
The bug is quite annoying when the API is heavy loaded (e.g., when Home Assistant copy snapshot on event)

[blakeblackshear]

No. I don't plan to solve it this way.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.