Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Proxmox LXC instructions; reference #5773 instead of #1111 #10759

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

m-d-brown
Copy link
Contributor

@m-d-brown m-d-brown commented Mar 30, 2024

There is a lot of confusing information online. This provides some simple general guidelines to help people get started.

This is a recreation of #10747.

There is a lot of confusing information online. This provides some
simple general guidelines to help people get started.
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 25468ca
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6609c84db8ba710008b58bf0
😎 Deploy Preview https://deploy-preview-10759--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Sponsor Collaborator

@NickM-27 NickM-27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things. Looks like checks are failing too

docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
docs/docs/frigate/installation.md Outdated Show resolved Hide resolved
@m-d-brown
Copy link
Contributor Author

Couple small things. Looks like checks are failing too

docker/main/rootfs/usr/local/go2rtc/create_config.py is failing ruff formatting checks prior to this PR. Do you want me to fix it here or fix it separately?

@NickM-27
Copy link
Sponsor Collaborator

Ahh I forgot it's that, yeah that's expected so no need to worry about the checks.

@m-d-brown m-d-brown changed the title Clarify Proxmox LXC instructions Clarify Proxmox LXC instructions; reference #5773 instead of #1111 Mar 31, 2024
@m-d-brown
Copy link
Contributor Author

Hi @NickM-27, do you merge as the next step? Or perhaps I'm missing something.

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Apr 3, 2024

Another maintainer will review and merge

@blakeblackshear blakeblackshear merged commit 2d5a3c6 into blakeblackshear:master Apr 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants