Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing frame_time argument to ObjectTracker.match_and_update() #10079

Merged

Conversation

SpangleLabs
Copy link
Contributor

And some little type hints.

Was just digging through the object tracker and noticed the args of the abstract class don't match the implementations.

I wondered whether more of the definition (including two identical methods between the implementations) should be pulled up into the superclass too, but that's a question of architecture. I wasn't sure if both implementations are used anymore

Also, I wondered whether you might be open to me making some PRs defining some types and type hints for the detections and boxes and stuff?

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit fd24ed3
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/65ddb72d41b1a8000873e4a2
😎 Deploy Preview https://deploy-preview-10079--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blakeblackshear
Copy link
Owner

PRs defining types and type hints would be greatly appreciated. Thanks for the PR.

@blakeblackshear blakeblackshear merged commit 7eb89ca into blakeblackshear:dev Feb 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants