Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Bring back Audio to Camera Live View and Review View #11826

Closed
tubalainen opened this issue Jun 9, 2024 · 16 comments
Closed

[UI] Bring back Audio to Camera Live View and Review View #11826

tubalainen opened this issue Jun 9, 2024 · 16 comments
Labels
enhancement New feature or request

Comments

@tubalainen
Copy link
Contributor

Describe what you are trying to accomplish and why in non technical terms
1.) When selecting a Audio capable camera from the start page, be able to listen to the audio of the camera in the Live Playback
2.) When reviewing events, same thing. When reviewing the clip from an Audio Capable Camera, hear the audio

Describe the solution you'd like
Bring back Audio to the new UI in 0.14.0.

Describe alternatives you've considered
Roll back to 0.13.x

Additional context
The audio is included when exporting clips. :)

@tubalainen tubalainen added the enhancement New feature or request label Jun 9, 2024
@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 9, 2024

  1. This is supported via the buttons in the top right
  2. There are audio controls for recordings as well

@NickM-27 NickM-27 closed this as completed Jun 9, 2024
@tubalainen
Copy link
Contributor Author

  1. This is supported via the buttons in the top right
  2. There are audio controls for recordings as well

Hi Nick - Thanks for your reply!

I made a boo-boo for the review part. There are audio options there. My mistake. Sorry.,
image

But I cannot get it to work in the "Live View". No Audio options.
image

Have I missed any config perhaps?

Thanks a billion!

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 9, 2024

The audio option only shows up when the camera has audio support

@tubalainen
Copy link
Contributor Author

The audio option only shows up when the camera has audio support

Odd, it works in the Review part of Frigate but not the Live View. Will check my config if you are 100% sure its not a bug. :)

@FrankRodelli
Copy link

FrankRodelli commented Jun 9, 2024

Here is how I got it working:

go2rtc:
  streams:
    kids_camera: 
         - rtsp:https://user:[email protected]/live0
         - "ffmpeg:kids_camera#audio=opus"
cameras:
  kids:
    live:
      stream_name: kids_camera

@tubalainen
Copy link
Contributor Author

tubalainen commented Jun 9, 2024

Here is how I got it working:

go2rtc:
  streams:
    kids_camera: 
         - rtsp:https://user:[email protected]/live0
         - "ffmpeg:kids_camera#audio=opus"
cameras:
  kids:
    live:
      stream_name: kids_camera

YOU ARE A STAR FRANK! Thanks a billion! Works great!

The reference config doesnt mention that the live: option can be used per camera (happy to make a PR).
And the reference config is referring to the camera_name. I think that it might be wrong, it should be stream name from go2rtc.
Do you agree @FrankRodelli ?

Here is my (full) example conf, note that the camera_name (as mentioned in the reference configuration) is different from the stream_name, just like in your example. Thanks for pointing that out Frank! 👍

go2rtc:
  streams:
    cam11_ch1:
      - rtsp:https://user:[email protected]:8554/Streaming/Channels/101
      - ffmpeg:cam11_ch1#audio=aac

cameras:
  cam11_inomhus:
    ffmpeg:
      inputs:
        - path: rtsp:/localhost:8554/cam11_ch1?video&audio
          input_args: preset-rtsp-restream
          roles:
            - detect
            - record
            - audio
      output_args:
        record: preset-record-generic-audio-aac
    live:
      stream_name: cam11_ch1

Thanks again.

@tubalainen
Copy link
Contributor Author

I don't get how the live: option is suppose to work on the "root level" of the config. Shouldn't it be a per camera: option only?

@FrankRodelli
Copy link

Yeah, I would say a more explicit description and placeholder name would help clear potential confusion there. I'd also agree having the live section being per-camera in the reference config is needed. It's correct in the "Live View" area in the docs, but some people may not get that far lol

I don't get how the live: option is suppose to work on the "root level" of the config. Shouldn't it be a per camera: option only?

Yeah, I don't think it was supposed to be root level of the config. I even tested what it did and it seemed like all my cams would show up as black except the one configured. Very weird and curious of there is reasoning.

I'm also not 100% if the config I shared/you shared will also record audio. It's possible the docs tell you to use a sub stream for the live view because the audio doesn't work otherwise. I'll do some testing and report that when I can.

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 9, 2024

There are other configs that apply globally and it's all held under the live config. The reference docs show that the entire live config can be set at the camera level.

@tubalainen
Copy link
Contributor Author

There are other configs that apply globally and it's all held under the live config. The reference docs show that the entire live config can be set at the camera level.

Absolutely, plenty of options that can be used per camera. But the documentation doesnt mention that live: is one of them. In the camera: -> back: it doesnt mention the live: option.

Personally, I dont see how is the live: option suppose to work on the "root level" of the config? Isnt it a per camera option only?

image

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 9, 2024

All of the fields besides camera_name make sense as a root level config.

Looks like the camera level text needs to be added.

@tubalainen
Copy link
Contributor Author

All of the fields besides camera_name make sense as a root level config.

Looks like the camera level text needs to be added.

On the docs. Happy to make a PR, as soon as we agree on the functionality.

Please check Franks comment above, I concur. The live: option doesn't work on the root level of the config. It is accepted (config control/QA check) but all cams except the one configured will be black.

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 9, 2024

Again, there are multiple fields in live. All of the fields work at the root level besides camera_name.

@tubalainen
Copy link
Contributor Author

Again, there are multiple fields in live. All of the fields work at the root level besides camera_name.

Fully agree on the other fields, the computes well with the rest of the setup.

The stream_name: should be the go2rtc stream name, right? Not the name of the camera?
image

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 9, 2024

Yes

tubalainen added a commit to tubalainen/frigate that referenced this issue Jun 9, 2024
Updated live: configuration.
Based on: blakeblackshear#11826
@tubalainen
Copy link
Contributor Author

I dont know what stream_name: defaults to nor how the logic works if one is not using go2rtc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants