Split out "full access" variants of frigate and frigate_beta add-ons #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "main" add-ons no longer enable full access, in order to improve their HA security ratings (while introducing "full access" variants for users with devices which don't work properly without disabling protection mode).
pauln
force-pushed
the
feature/split-full-access
branch
from
a4f7f0d
to
f9d19b1
Compare
Reinstates changes missed in the rebase, and tweaks the beta full access variant from frigate_beta_fa to frigate_fa_beta so that "beta" remains a suffix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables full hardware access on the base
frigateandfrigate_betaaddons, and introduces new "full access" variants (frigate_faandfrigate_beta_fa) with a note in their respective READMEs stating why they enable full device access. This boosts the addons' security ratings from 1 (lowest) to 6 (highest), which should reduce the chances of potential new users being put off by the security rating.If somebody knows which specific devices require full access, it might be worth adding the details - both to the READMEs and to the docs site.
This comes out of discussion in PR #24 - and in conjunction with other recent commits, this PR closes #24.