Update tests for pydicom 2.3 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of pydicom 2.3.0 values are more rigorously tested for validity. The following problems were observed: * some PatientBirthTime attributes had illegal colons in them * some SHs were too long
Prior to pydicom 2.3.0, assigning a single-element list value would keep the value as a list. As of 2.3.0, the value is stored as the single value. pydicom/pydicom#1606
Prior to pydicom 2.3.0, assigning a single-element list value would keep the value as a list. As of 2.3.0, the value is stored as the single value. pydicom/pydicom#1606
YYYY and YYYYMM were never valid, but we were testing them anyhow. pydicom 2.3 started validating value lengths, so these tests were throwing errors unrelated to dicognito's functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.