This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
Service dependency against a minimal ggn version #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a service declares a dependency against a minimal version of GGN, unit file generation for this service ill be blocked if ggn doesn't fullfill version requirement. This allow to safely upgrade service manifest and prevent service operation with uncompatible ggn versions.
n0rad
reviewed
Feb 3, 2017
work/spec.go
Outdated
| @@ -42,6 +42,7 @@ type HookInfo struct { | |||
| } | |||
|
|
|||
| type ServiceManifest struct { | |||
| GgnMinimalVersion common.Version `yaml:"ggnminimalversion"` | |||
n0rad
reviewed
Feb 3, 2017
work/service-generate.go
Outdated
| logs.WithField("version", s.manifest.GgnMinimalVersion).Debug("Found ggn minimal version") | ||
| if s.manifest.GgnMinimalVersion.GreaterThan(currentVersion) { | ||
| logs.WithFields(s.fields). | ||
| WithField("ggn-minimalversion", s.manifest.GgnMinimalVersion). |
There was a problem hiding this comment.
you can remove ggn- it's useless while coming with the comment.
added 2 commits
February 3, 2017 12:23
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a service declares a dependency against a minimal version of ggn, unit file generation for this service ill be blocked if ggn doesn't fullfill version requirement.
This allow to safely upgrade service manifest and prevent service operation with uncompatible ggn versions.