A few quality of life visual changes #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done so that terminal data remains static in the progress string when it changes from e.g. 9.0 to 10.0
Length is fixed to total divided by sector size Done so that terminal data remains static in the progress string when it changes from e.g. 768 to 1024 sectors
Useful to clear previous data if line's length decreases
To keep consistency with original progress message and ensure users know how many total sectors have been written.
|
Very cool. Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes just make it so that the terminal line doesn't end up looking like:
Progress: |██████████████████████████████████████████████████| 100.0% Completector 7936 of 8192) 40.00 MB/sat the end of writing and instead it looks like:
Progress: |██████████████████████████████████████████████████| 100.0% Write Complete (Sector 8192 of 8192)