Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to draw straight lines #67

Closed
TravelTrader opened this issue Apr 7, 2019 · 7 comments · Fixed by #193
Closed

Add functionality to draw straight lines #67

TravelTrader opened this issue Apr 7, 2019 · 7 comments · Fixed by #193

Comments

@TravelTrader
Copy link

TravelTrader commented Apr 7, 2019

#44 is similar but I want to open it as a feature-request.
Because it would be a great possibility to add lines to Gromit.

I would help with the code if there is interest and support because I'm not a graphics programmer.

Pressing a key to start a line in the same color like the "freehand" option and hold it down until the end point of the line is reached. Simple like the other tools but a new feature.

What do you think? Why not?

@bk138
Copy link
Owner

bk138 commented Apr 7, 2019

Some thoughts:

@bk138
Copy link
Owner

bk138 commented Jul 3, 2019

General update: issues with Gromit-MPX can now be funded at https://issuehunt.io/r/bk138/gromit-mpx

@bk138 bk138 changed the title possible to add a line function (optional: rectangles, circles, ...)? Add functionality to draw straight lines Nov 14, 2020
@bk138 bk138 added the tool label Dec 5, 2020
@bk138 bk138 added this to the Release 1.5 milestone Dec 6, 2020
@bk138 bk138 modified the milestones: Release 1.5, Release 1.6 Jul 1, 2021
natenho added a commit to natenho/gromit-mpx that referenced this issue Oct 13, 2021
@Cybernetic1
Copy link

I'd like to contribute. Which file(s) and where abouts should I start looking? Why is such a simple feature taking so long to implement? Thanks :)

@bk138
Copy link
Owner

bk138 commented Dec 11, 2021

I'd like to contribute. Which file(s) and where abouts should I start looking? Why is such a simple feature taking so long to implement? Thanks :)

Thanks for your interest! See my comments here. This simple feature takes so long to implement because of lack of time, at least on my side :-)

@borys-upco
Copy link

borys-upco commented Jul 8, 2022

Hi. Is there any chance to push forward this feature and get it implemented?

@bk138
Copy link
Owner

bk138 commented Jul 8, 2022

Hi. Is there any chance to push forward this feature and get it implemented?

Yes, one might file a "bounty" via https://issuehunt.io/r/bk138/gromit-mpx/issues/67 so some interested party feels incentivized to implement this; basically anyone, not necessarily me.

The other option would be to hire me to spend paid work time on this feature, that'd be via https://christianbeier.net.

The last option is to simply wait it out, it's on my agenda for the project, but I'm currently very busy with customers and family, so no better ETA on the horizon than "some time in the future".

@borys-upco
Copy link

@bk138 Perfect it is not urgent, I can live without it. Maybe I will motivate my self and learn c and gtk.
It is hard from the JS and C# World.

@bk138 bk138 linked a pull request Mar 2, 2024 that will close this issue
@bk138 bk138 closed this as completed in #193 Mar 2, 2024
bk138 added a commit that referenced this issue Mar 2, 2024
pascal-niklaus pushed a commit to pascal-niklaus/gromit-mpx that referenced this issue Mar 2, 2024
bk138 added a commit that referenced this issue Mar 11, 2024
…ow position

* drawing, config, callbacks: add arrowtype option allowing arrow heads at both line ends

re #67

* main.h: enum names changed for arrow types

* config: don't set arrow type to none when size is defined

---------

Co-authored-by: Christian Beier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants