Remove dead code

[oterral]

In our project https://github.com/geops/openlayer-editor, we use jsts as es6 import and after compilation we have this issue in the browser console:

Uncaught SyntaxError: Identifier 't' has already been declared

2 generated variables by the compiler have the same name .
It seems it' caused by some dead code in DirectedEdgeStar.js, Removing it fix our issue.

[codecov]

Codecov Report

Merging #384 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   62.46%   62.45%   -0.01%     
==========================================
  Files         280      280              
  Lines       14327    14325       -2     
==========================================
- Hits         8949     8947       -2     
  Misses       5378     5378

Impacted Files	Coverage Δ
...org/locationtech/jts/geomgraph/DirectedEdgeStar.js	82.38% <ø> (-0.22%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efe352b...211483c. Read the comment docs.

[bjornharrtell]

Nice catch, but I'd like to fix this upstream.

[bjornharrtell]

Ah.. I see the issue is caused by that the same local var name is in overloads.. this is of course nothing illegal in Java so it's a transpilation issue but seemingly rare.

[oterral]

java is more permissive than js , the world becomes crazy :D

[oterral]

Thx to have fix this upstream !!

[bjornharrtell]

Fixed by d74c9ce

[oterral]

Hi @bjornharrtell ! when did you plan the next release of jsts?

[bjornharrtell]

Don't know ;)

[bjornharrtell]

I note that there are many more instances of duplicate declarations due to an oversight in the transpiration that I'd like to fix but unfortunately it is not trivial. I wonder why this particular instance cause you trouble and others not though ..

[bjornharrtell]

Underlying issue tracked by #386

[oterral]

Probably because we don't use all the library. Where have you seen the same kind of duplicat declarations ? , I can have a look how it's transpiled in our code.

[bjornharrtell]

On latest master you can run yarn lint and it will give you a large list of duplicate declarations (and some other issues) starting with:

jsts/src/org/locationtech/jts/algorithm/Area.js
39:11 error 'x0' is already defined no-redeclare
41:11 error 'sum' is already defined no-redeclare
42:16 error 'i' is already defined no-redeclare
...