增加证书相关功能 #226
Merged
增加证书相关功能 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wsczx
commented
Mar 31, 2023
wsczx
commented
- 新增支持自定义上传证书功能
- 新增支持申请和自动续期Let's Encrypt证书（暂只支持阿里云和腾讯云）功能
- 新增支持动态加载证书（更换证书不需重启）功能
* 新增支持申请和自动续期Let's Encrypt证书（暂只支持阿里云和腾讯云）功能 * 新增支持动态加载证书（更换证书不需重启）功能
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## dev #226 +/- ##
==========================================
- Coverage 20.54% 19.16% -1.38%
==========================================
Files 61 63 +2
Lines 3812 4086 +274
==========================================
Hits 783 783
- Misses 2907 3181 +274
Partials 122 122
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bjdgyc
reviewed
Apr 3, 2023
server/handler/server.go
Outdated
| @@ -48,6 +48,13 @@ func startTls() { | |||
| NextProtos: []string{"http/1.1"}, | |||
| MinVersion: tls.VersionTLS12, | |||
| CipherSuites: selectedCipherSuites, | |||
| GetCertificate: func(*tls.ClientHelloInfo) (*tls.Certificate, error) { | |||
| cert, err := tls.LoadX509KeyPair(base.Cfg.CertFile, base.Cfg.CertKey) | |||
There was a problem hiding this comment.
确实会有一些影响，但是可以保证实时动态加载证书，或者用一个定时器来定期读取证书文件？
|
现在证书有三个地方都可以配置， |
|
没有优先级，上传和Let's Encrypt会覆盖配置文件里面设置的证书文件 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.