[PM-9407] Confirm overwrite existing passkey in edit mode #3542
+263
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user-verificatoin-add-edit-item
…user-verification-state-tracking-add-edit-item # Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt # app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt
…g' into PM-9407/replace-existing-passkey-addedit
SaintPatrck
requested review from
david-livefront,
dseverns-livefront,
shannon-livefront and
a team
|
No New Or Fixed Issues Found |
…replace-existing-passkey-addedit # Conflicts: # app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3542 +/- ##
==========================================
- Coverage 87.48% 87.48% -0.01%
==========================================
Files 359 359
Lines 29397 29420 +23
Branches 4366 4371 +5
==========================================
+ Hits 25719 25738 +19
- Misses 2118 2120 +2
- Partials 1560 1562 +2 ☔ View full report in Codecov by Sentry. |
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModelTest.kt
Show resolved
Hide resolved
shannon-livefront
previously approved these changes
Jul 17, 2024
SaintPatrck
dismissed stale reviews from shannon-livefront and dseverns-livefront
via
72743e9
dseverns-livefront
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-9407
📔 Objective
Prompt the user to confirm saving a new passkey to a cipher and overwriting the existing passkey.
📸 Screenshots
Coming soon!
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes