PM-9659: Do not show push notification permissions on FDroid #3528
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3528 +/- ##
=======================================
Coverage 87.47% 87.48%
=======================================
Files 359 359
Lines 29456 29460 +4
Branches 4376 4378 +2
=======================================
+ Hits 25768 25772 +4
Misses 2126 2126
Partials 1562 1562 ☔ View full report in Codecov by Sentry. |
david-livefront
force-pushed
the
PM-9659-fdroid-permissions
branch
from
09bbeba
to
34ae45d
Compare
dseverns-livefront
previously approved these changes
Jul 16, 2024
david-livefront
force-pushed
the
PM-9659-fdroid-permissions
branch
from
34ae45d
to
7225504
Compare
david-livefront
force-pushed
the
PM-9659-fdroid-permissions
branch
from
7225504
to
49d2a97
Compare
brian-livefront
approved these changes
Jul 18, 2024
|
Thanks @dseverns-livefront & @brian-livefront |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-9659
📔 Objective
This PR disables the push notifications permission request on FDroid since we do not use push notifications on FDroid.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes