Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in cli #951

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix some typos in cli #951

wants to merge 9 commits into from

Conversation

mrs1669
Copy link

@mrs1669 mrs1669 commented Apr 28, 2024

  1. enviro ments -> environments
  2. ou put -> output
  3. tim out -> timeout

(updated)

@lpusok
Copy link
Contributor

lpusok commented Apr 30, 2024

Thanks. Under the vendor/ folder we store vendored dependencies, please do not edit them. Any issue there has to be fixed in the dependency's repository.

@mrs1669 mrs1669 changed the title Fix some typos Fix some typos in cli May 6, 2024
@mrs1669
Copy link
Author

mrs1669 commented May 6, 2024

Thanks. Under the vendor/ folder we store vendored dependencies, please do not edit them. Any issue there has to be fixed in the dependency's repository.

@lpusok
Thank you, I understand!
I deleted the differences under the "vendor" folder. I have submitted a PR in the dependency's repository.
bitrise-io/envman#220

@lpusok
Copy link
Contributor

lpusok commented May 16, 2024

main.go:3:8: could not import github.com/bitrise-io/bitrise/cli (-: # github.com/bitrise-io/bitrise/cli
cli/run.go:37:2: OutputFormatKey redeclared in this block
	cli/commands.go:20:2: other declaration of OutputFormatKey) (typecheck)
import "github.com/bitrise-io/bitrise/cli"
       ^
cli/agent.go:1: : # github.com/bitrise-io/bitrise/cli [github.com/bitrise-io/bitrise/cli.test]
cli/run.go:37:2: OutputFormatKey redeclared in this block
	cli/commands.go:20:2: other declaration of OutputFormatKey (typecheck)
package cli
: # github.com/bitrise-io/bitrise/cli [github.com/bitrise-io/bitrise/cli.test]
cli/run.go:37:2: OutputFormatKey redeclared in this block
	cli/commands.go:20:2: other declaration of OutputFormatKey```
Does not build sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants