create-github-app-token 1.0.0 #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Don't forget to follow semantic versioning! Breaking changes (including step inputs) should be in major versions only.
|
godrei
reviewed
Aug 30, 2024
| bash: | ||
| entry_file: step.sh | ||
| inputs: | ||
| - github_repository: null |
There was a problem hiding this comment.
As far as I can see in GitHub documentation this input should be in the {owner}/{repo} format, is it correct? If so it is worth mentioning this in the Step Input's summary or description.
|
Hi @tdrk18 thanks for the new Step, I left one suggestion, which you might fix in future Step versions, other than that the PR looks good to me! |
godrei
approved these changes
Aug 30, 2024
|
Hi @godrei thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.
bitrise run test(in the step's repository)bitrise run audit-this-step(in the step's repository - note, if you don't have this workflow in yourbitrise.yml, you can copy it from the step template.)New Step
Thank you for the new Step share! The CI check might will fail due to our extended validation engine. Nothing to worry about yet, we will get back to you shortly.