Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHIB to Currency model #20

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Add SHIB to Currency model #20

merged 1 commit into from
Dec 30, 2021

Conversation

Krymonota
Copy link
Contributor

No description provided.

@Krymonota
Copy link
Contributor Author

I just saw that @alexstewartja created (and closed) a pull request an hour ago: #19 (what a coincidence 😆)

@alexstewartja So I'm not sure what you're up to, but if you're planning to resubmit your pull request (which includes more currency additions and features), I'd be happy to discard my pull request :-)

@alexstewartja
Copy link
Contributor

@Krymonota Hey, thanks for noticing! It was a mess due to a bug in how GitKraken handles squash merge history. I'll recreate the PR a little later 🚀

@anbugal anbugal merged commit b32dc81 into bitpay:master Dec 30, 2021
@alexstewartja
Copy link
Contributor

alexstewartja commented Dec 30, 2021

I just saw that @alexstewartja created (and closed) a pull request an hour ago: #19 (what a coincidence 😆)

@alexstewartja So I'm not sure what you're up to, but if you're planning to resubmit your pull request (which includes more currency additions and features), I'd be happy to discard my pull request :-)

@Krymonota Just opened #21 . Wasn't going to ruin your 1st contribution, an important contribution, I might add. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants