Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/grafana-operator] Update the grafana-operator chart to version 4.x release. #8059

Merged
merged 65 commits into from
Dec 29, 2021

Conversation

Cellebyte
Copy link
Contributor

@Cellebyte Cellebyte commented Nov 8, 2021

Description of the change

It updates the CRD's from the project and the operator to the v4.0.x release.

Benefits

Better validation of the CRD Resources via API-Server and third-party tools.
Reduced rbac roles.
Leader Election for better HA support of the operator.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/<name_of_the_chart>])

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

Great PR! Please pay attention to the following items before merging:

Files matching bitnami/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files

@Cellebyte Cellebyte changed the title [bitnami/grafana-operator] Update the grafana-operator chart to version 4.x release. DRAFT: [bitnami/grafana-operator] Update the grafana-operator chart to version 4.x release. Nov 9, 2021
@carrodher
Copy link
Member

Hi @Cellebyte, is this PR ready for review, or are you planning more tests/changes on your side? I'm asking because of the DRAFT: that appears in the title. Feel free to ping me once it is ready for review. Thanks!

@Cellebyte Cellebyte changed the title DRAFT: [bitnami/grafana-operator] Update the grafana-operator chart to version 4.x release. [bitnami/grafana-operator] Update the grafana-operator chart to version 4.x release. Nov 9, 2021
@Cellebyte
Copy link
Contributor Author

Cellebyte commented Nov 9, 2021

@carrodher we still need to wait until the upstream changes are implemented.
Then build a new operator version and then bump it here and merge it. I will notify here when it is time to review and merge it.

@carrodher
Copy link
Member

Thanks for the changes @Cellebyte, I just pinged @juan131 in a related PR he already created (see above link) so you can work together if needed

@Cellebyte
Copy link
Contributor Author

Cellebyte commented Nov 9, 2021

@carrodher I already added a comment with a clarification from my perspective what makes more sense.

@juan131
Copy link
Contributor

juan131 commented Dec 13, 2021

@joancafom are we ready to go with this?

@Cellebyte
Copy link
Contributor Author

@juan131 please do not merge until we have fixed the grafana image :D

@javsalgar
Copy link
Contributor

@Cellebyte could you try merging the changes I added in this PR so we don't bump the chart twice? #8513

@Cellebyte
Copy link
Contributor Author

@javsalgar will do that :)

@Cellebyte
Copy link
Contributor Author

@javsalgar could you regenerate the readme from the new values.yaml file.

@javsalgar
Copy link
Contributor

@Cellebyte updated

@javsalgar
Copy link
Contributor

@Cellebyte I want to launch our automated test suite and, in case it succeeds, proceed with the automatic merge, any blockers?

@Cellebyte
Copy link
Contributor Author

@javsalgar From my side it should be done.

@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/grafana-operator:4.1.1-debian-10-r14"
  • "docker.io/bitnami/grafana:8.3.3-debian-10-r14"

@javsalgar javsalgar merged commit d87dec2 into bitnami:master Dec 29, 2021
@Cellebyte
Copy link
Contributor Author

Finally it’s done thanks to all of you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
10 participants