Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitname/mongodb] fixed comment in values.yaml #5650

Merged
merged 2 commits into from
Mar 2, 2021
Merged

[bitname/mongodb] fixed comment in values.yaml #5650

merged 2 commits into from
Mar 2, 2021

Conversation

modularTaco
Copy link
Contributor

Description of the change

Fixed a comment in the values.yaml where rabbitmq.fullname instead of mongodb.fullname was specified, whereas in the README.md it was mongodb.fullname.

Benefits

README.md and values.yaml are consistent

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

carrodher
carrodher approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@carrodher carrodher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a copy/paste typo, thanks for the fix!

@carrodher carrodher merged commit 6282c06 into bitnami:master Mar 2, 2021
miguelaeh pushed a commit to miguelaeh/bitnami-charts that referenced this pull request Apr 6, 2021
@modularTaco @miguelaeh
[bitname/mongodb] fixed comment in values.yaml (bitnami#5650)
be2d1ae 
* fixed comment in values

* bump chart version

Co-authored-by: modularTaco <none>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carrodher carrodher carrodher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@modularTaco @carrodher