Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kube-prometheus] Add possibility to pull images without giving registry name #5638

Merged
merged 1 commit into from
Mar 2, 2021
Merged

[bitnami/kube-prometheus] Add possibility to pull images without giving registry name #5638

merged 1 commit into from
Mar 2, 2021

Conversation

EtienneBarbier
Copy link
Contributor

Description of the change

Add possibility to pull images prometheusConfigReload Image without giving specific registry in Values.yaml file but by setting default registry on host. See #5582

Benefits

We can use non default prometheusConfigReload if we omit .Values.operator.prometheusConfigReloader.image.registry

Possible drawbacks

We cannot use default behavior for prometheusConfigReload by omitting .Values.operator.prometheusConfigReloader.image.registry, we need to omit imageName or imageTag.

Applicable issues

Additional information

None

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

@EtienneBarbier EtienneBarbier changed the title Add possibility to pull images without giving registry name [bitnami/kube-prometheus] Add possibility to pull images without giving registry name Mar 1, 2021
Copy link
Contributor

@alemorcuq alemorcuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alemorcuq alemorcuq merged commit 6701f61 into bitnami:master Mar 2, 2021
miguelaeh pushed a commit to miguelaeh/bitnami-charts that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/kube-prometheus] Prometheus Operator Reloader image weird behavior
2 participants