Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/*] Update ingress for serveral charts #5012

Merged
merged 26 commits into from
Jan 15, 2021

Conversation

miguelaeh
Copy link
Contributor

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks good! Just a couple of comments, please take a look at them.

bitnami/thanos/templates/query/ingress-grpc.yaml Outdated Show resolved Hide resolved
bitnami/wildfly/values.yaml Show resolved Hide resolved
Copy link
Contributor

@FraPazGal FraPazGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miguelaeh miguelaeh merged commit e3bb5a6 into bitnami:master Jan 15, 2021
@miguelaeh miguelaeh deleted the ingress branch January 15, 2021 09:45
Cellebyte pushed a commit to Cellebyte/charts that referenced this pull request Feb 12, 2021
* Update ingress for wildfly

* Update ingress for tomcat

* Update thanos ingress

* Update testlink ingress

* Update suitecrm ingress

* Update spring cloud dataflow ingress

* Update spark ingress

* Update redmine ingress

* Update rabbitmq ingress

* Update prestashop ingress

* Update phpmyadmin ingress

* Update phpbb ingress

* Revert "Update phpbb ingress"

This reverts commit a7a1668.

* Revert "Update phpmyadmin ingress"

This reverts commit eef3d95.

* Revert "Update prestashop ingress"

This reverts commit 5676c9b.

* Revert "Update rabbitmq ingress"

This reverts commit c228cac.

* Revert "Update redmine ingress"

This reverts commit 1db59ce.

* Revert "Update spark ingress"

This reverts commit ca7413e.

* Revert "Update spring cloud dataflow ingress"

This reverts commit b400a3e.

* Update dependencies

* Add missing values to wildfly README

* Fix thanos port name

* Update dependencies

* Bump minio major in thanos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants