Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redmine] Adapt ingress to k8s 1.20 #5008

Merged
merged 1 commit into from
Jan 15, 2021
Merged

[bitnami/redmine] Adapt ingress to k8s 1.20 #5008

merged 1 commit into from
Jan 15, 2021

Conversation

javsalgar
Copy link
Contributor

Description of the change

This PR updates the common library with the changes from #4859.

  • Depending on the Kubernetes version it will generate the proper Ingress object
  • It allows forcing a Kubernetes version so it is compatible with GitOps approaches

Benefits

Charts compatible with all Kubernetes versions
Possible drawbacks

n/a
Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

@rafariossaa
Copy link
Contributor

Hi,
Could you take a look to the linter test ? it is complaining about a missing lookup function.

@javsalgar
Copy link
Contributor Author

This is due to the recent changes in the common function. The helm version we are using in the CI does not have it.

@rafariossaa
Copy link
Contributor

LGTM

@javsalgar javsalgar merged commit 66eafb7 into master Jan 15, 2021
@javsalgar javsalgar deleted the redmingress branch January 15, 2021 09:06
Cellebyte pushed a commit to Cellebyte/charts that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants