[bitnami/mariadb-galera] Fix pod labels #4643
Conversation
srueg
force-pushed
the
mariadb-galera/pod-labels
branch
from
50adb69
to
ff9a0d0
Compare
marcosbc
added
the
on-hold
|
Nice, I didn't see this issue before. As I commented there, the |
|
It seems like you are correct. In any case, for now, let's block this PR until we decide how to approach these changes in #4455. |
* Don't use the chart as pod label. Otherwise this will cause a pod restart on every release, even if the pod template didn't change. Signed-off-by: Simon Rüegg <[email protected]>
srueg
force-pushed
the
mariadb-galera/pod-labels
branch
from
ff9a0d0
to
7933792
Compare
|
@marcosbc Any update on this? |
There was a problem hiding this comment.
Hi @srueg, I'm so sorry for the long delay. In the end we did not reach any conclusion in #4455 so we didn't add any update here.
After checking with the team, this PR looks good for everyone and there are no concerns, as it does not affect immutable fields (like you mentioned earlier).
Therefore, I'm going to accept this and merge now. Thanks a lot for the contribution!
|
Thanks @marcosbc |
|
@srueg We have been working on fixing an issue that appeared with this change. It seems to be working now so a new chart release should happen soon, hopefully today. |
* Don't use the chart as pod label. Otherwise this will cause a pod restart on every release, even if the pod template didn't change. Signed-off-by: Simon Rüegg <[email protected]>
carrodher
removed
the
on-hold
Description of the change
Benefits
Otherwise this will cause a pod restart on every release, even if the pod didn't change.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.[bitnami/chart])values-production.yamlapart fromvalues.yaml, ensure that you implement the changes in both files