Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix allstar binary artifacts check #51

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Fix allstar binary artifacts check #51

merged 1 commit into from
Sep 27, 2022

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Sep 27, 2022 •
edited
Loading

🚀 Description

Add ignorePaths for Gradle wrapper

📄 Motivation and Context

Gradle wrapper is a standard setup for Java/Android projects and is also backed up by the gradle/wrapper-validation-action

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

✅ Checklist

  • My code follows the code style and naming conventions of this project.
  • I have updated the documentation (if appropriate).
  • I have updated the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wmontwe
Create binary_artifacts.yaml
97b3694 
Add ignorePaths for Gradle wrapper
@wmontwe wmontwe added this to the 0.1.0 milestone Sep 27, 2022
@wmontwe wmontwe self-assigned this Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022 •
edited
Loading

Warnings
⚠️ Changes should be reflected in the CHANGELOG.md

Generated by 🚫 Danger Kotlin against 97b3694

@wmontwe wmontwe changed the title Create binary_artifacts.yaml Fix allstar binary artifacts check Sep 27, 2022
@wmontwe wmontwe linked an issue Sep 27, 2022 that may be closed by this pull request
Security Policy violation Binary Artifacts #7
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wmontwe
wmontwe commented Sep 27, 2022
View reviewed changes
Copy link
Member Author

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wmontwe wmontwe added the ci CI/CD label Sep 27, 2022
@wmontwe wmontwe merged commit 1564d82 into main Sep 27, 2022
@wmontwe wmontwe deleted the feature/fix-allstar-binary-artifacts branch September 27, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wmontwe wmontwe

Labels
ci CI/CD
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Security Policy violation Binary Artifacts
1 participant
@wmontwe