Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to bitfunk Gradle plugins #82

Merged
merged 8 commits into from
Dec 21, 2022
Merged

Change to bitfunk Gradle plugins #82

merged 8 commits into from
Dec 21, 2022

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 18, 2022 •
edited
Loading

🚀 Description

Replace local plugins partially by bitfunk/gradle-plugins

📄 Motivation and context

Reduce project configuration time and reuse plugins in other projects

📦 Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

✅ Checklist

  • My code follows the code style and naming conventions of this project.
  • I have updated the documentation (if appropriate).
  • I have updated the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wmontwe wmontwe added this to the 2.0.0 milestone Nov 18, 2022
@wmontwe wmontwe self-assigned this Nov 18, 2022
@github-actions github-actions bot added app-android App Android app-desktop App Desktop build build tools common Common feature changes configuration Gradle configuration changes documentation Improvements or additions to documentation feature Feature changes labels Nov 18, 2022
@github-actions
Copy link

github-actions bot commented Nov 18, 2022 •
edited
Loading

Warnings
⚠️ Changes should be reflected in the CHANGELOG.adoc

Generated by 🚫 Danger Kotlin against 6967fa2

@wmontwe
Copy link
Member Author

wmontwe commented Nov 18, 2022

👍

github-actions[bot]
github-actions bot previously approved these changes Nov 18, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go.

@wmontwe
Copy link
Member Author

wmontwe commented Dec 21, 2022

👍

github-actions[bot]
github-actions bot approved these changes Dec 21, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready to go.

@wmontwe wmontwe merged commit 9e61730 into main Dec 21, 2022
@wmontwe wmontwe deleted the feature/change-to-bitfunk-plugins branch December 21, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@wmontwe wmontwe

Labels
app-android App Android app-desktop App Desktop build build tools common Common feature changes configuration Gradle configuration changes documentation Improvements or additions to documentation feature Feature changes
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wmontwe