Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): BIP 329 import/export labels #1526

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(wallet): BIP 329 import/export labels #1526

wants to merge 1 commit into from

Conversation

storopoli
Copy link
Contributor

Description

Adds BIP 329 label import export functionality
into the bdk_wallet crate.

This is feature-gated to the "labels" feature.

Closes #848.

Notes to the reviewers

This is a WIP.
I am still missing tests, but I want to first discuss if this is the right approach.

Changelog notice

  • feat(bdk_wallet): BIP 329 label import/export support

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@storopoli
feat(wallet): BIP 329 import/export labels
f3a5cbb 
Adds BIP 329 label import export functionality
into the `bdk_wallet` crate.

This is feature-gated to the `"labels"` feature.
@storopoli storopoli mentioned this pull request Jul 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BIP 329 "Wallet Labels Export Format" Support
1 participant
@storopoli