Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP 39: Аdd swift library with multi lang support #672

Merged
merged 4 commits into from
Jun 1, 2020

Conversation

skywinder
Copy link
Contributor

@skywinder skywinder commented Apr 9, 2018

Add one more swift library to generate mnemonics (with multi lang support)
Here is an implementation:
https://github.com/matter-labs/web3swift/blob/e36e767eb2de26decb0c157aeef2d023a1175076/Sources/web3swift/KeystoreManager/BIP39.swift#L72

add one more library to generate mnemonics (with multilang support)
@skywinder skywinder changed the title Update bip-0039.mediawiki Update bip-0039.mediawiki - added swift library with multi lang support Apr 9, 2018
@skywinder skywinder changed the title Update bip-0039.mediawiki - added swift library with multi lang support BIP 39: Аdd swift library with multi lang support Apr 9, 2018
@skywinder
Copy link
Contributor Author

@luke-jr please, kindly check this small addition 😉

@skywinder
Copy link
Contributor Author

We moved our repo to the new address. I updated URL. Please, kindly check. 👍

@luke-jr
Copy link
Member

luke-jr commented Apr 30, 2020

@prusnak
Copy link
Contributor

prusnak commented Apr 30, 2020

NAK. The URL points to the library that does other 1000 things than BIP39.

Maybe if the URL pointed to the relevant file ...

@luke-jr luke-jr closed this Apr 30, 2020
@@ -165,6 +165,7 @@ Rust:
Swift:
* https://github.com/CikeQiu/CKMnemonic
* https://github.com/yuzushioh/WalletKit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Would like to mention, that other links doesn't direect to the class itself)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They include the example of how generate a mnemonic right on top of their readme.

@skywinder
Copy link
Contributor Author

Maybe if the URL pointed to the relevant file ...

@luke-jr @prusnak can you reopen this PR, so I will update the link to the corresponding class? (or should I make another PR with the correct link? i.e. web3swift/KeystoreManager/BIP39.swift

@luke-jr luke-jr reopened this Apr 30, 2020
@skywinder
Copy link
Contributor Author

Done, @luke-jr

@@ -165,6 +165,7 @@ Rust:
Swift:
* https://github.com/CikeQiu/CKMnemonic
* https://github.com/yuzushioh/WalletKit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They include the example of how generate a mnemonic right on top of their readme.

@@ -165,7 +165,8 @@ Rust:
Swift:
* https://github.com/CikeQiu/CKMnemonic
* https://github.com/yuzushioh/WalletKit
* https://github.com/matter-labs/web3swift (`BIP39` public class)
* https://github.com/matter-labs/web3swift/blob/develop/Sources/web3swift/KeystoreManager/BIP39.swift
* https://github.com/matter-labs/web3swift/blob/develop/Sources/web3swift/KeystoreManager/BIP39.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once is enough

@luke-jr luke-jr merged commit 2a6386b into bitcoin:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants