Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing whitespace from all BIPs #1653

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Remove trailing whitespace from all BIPs #1653

merged 1 commit into from
Jul 26, 2024

Conversation

OrfeasLitos
Copy link
Contributor

No description provided.

@OrfeasLitos OrfeasLitos mentioned this pull request Jul 25, 2024
Merged
jonatack
jonatack reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK. Did you find these manually or use a tool? Perhaps an automated task could be added to the workflow checks.

@OrfeasLitos
Copy link
Contributor Author

I just did sed -i "s/ *$//" *.mediawiki in the bips/ directory. An automated task is a good idea.

jonatack
jonatack reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9a56d35

Happy to review a pull to add an automated task.

@jonatack jonatack merged commit 0f40dd7 into bitcoin:master Jul 26, 2024
3 checks passed
@jonatack jonatack mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatack jonatack jonatack left review comments

@ProofOfKeags ProofOfKeags ProofOfKeags approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OrfeasLitos @jonatack @ProofOfKeags