BIP-0386: Fix uncompressed private key test vector #1631
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
525411
approved these changes
Jul 23, 2024
jonatack
reviewed
Jul 24, 2024
| @@ -101,7 +101,7 @@ Valid descriptors followed by the scripts they produce. Descriptors involving de | |||
|
|
|||
| Invalid Descriptors | |||
|
|
|||
| * Uncompressed private key: <tt>tr(5kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss)</tt> | |||
| * Uncompressed private key: <tt>tr(5KYZdUEo39z3FPrtuX2QbbwGnNP5zTd7yyr2SC1j299sBCnWjss)</tt> | |||
There was a problem hiding this comment.
Change LGTM
before
$ ./src/bitcoin-cli getdescriptorinfo "tr(5kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss)"
error code: -5
error message:
tr(): key '5kyzdueo39z3fprtux2qbbwgnnp5ztd7yyr2sc1j299sbcnwjss' is not valid
after
$ ./src/bitcoin-cli getdescriptorinfo "tr(5KYZdUEo39z3FPrtuX2QbbwGnNP5zTd7yyr2SC1j299sBCnWjss)"
error code: -5
error message:
tr(): Uncompressed keys are not allowed
and with this change, returns the same error as the example on the following line (105)
$ ./src/bitcoin-cli getdescriptorinfo "tr(04a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd5b8dec5235a0fa8722476c7709c02559e3aa73aa03918ba2d492eea75abea235)"
error code: -5
error message:
tr(): Uncompressed keys are not allowed
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
cc @achow101 for feedback |
|
ACK 7acfe20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base58 in the WIF format is case sensitive.
The following Test Vector will result in an error indicating the WIF version is invalid, regardless of the compression state of the public key.
The following is probably what was intended: