-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bip-0015.mediawiki #1611
Conversation
Fix broken link to vanitygen. See https://archive.ph/iY5oI This is an attempt to change the destination link... FROM: https://bips.dev/15/vanitygen TO: https://github.com/klynastor/supervanitygen ...using the syntax of Github Mediawiki format as defined here: https://github.com/bitcoin/bips/blob/70d9b07ab80ab3c267ece48f74e4e2250226d0cc/scripts/link-format-chk.sh#L4
@@ -36,7 +36,7 @@ Their FirstBits alias becomes: | |||
|
|||
It is enough information to be given the FirstBits alias ''1brmlab''. When someone wishes to make a purchase, without FirstBits, they either have to type out their address laboriously by hand, scan their QR code (which requires a mobile handset that this author does not own) or find their address on the internet to copy and paste into the client to send bitcoins. FirstBits alleviates this impracticality by providing an easy method to make payments. | |||
|
|||
Together with [[vanitygen|Vanitygen (vanity generator)]], it becomes possible to create memorable unique named addresses. Addresses that are meaningful, rather than an odd assemblage of letters and numbers but add context to the destination. | |||
Together with [vanitygen https://github.com/klynastor/supervanitygen], it becomes possible to create memorable unique named addresses. Addresses that are meaningful, rather than an odd assemblage of letters and numbers but add context to the destination. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell from the commit history of this repository, this link was always broken. Rather than assigning it a destination that may or may not match the BIP Champion’s intention, it would be preferable to remove the link altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be preferable to remove the link altogether.
Good point.
I have emailed the BIP Champion for his input and asked him to review this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Closing this PR and going with #1618 instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm typing this in the "Finish your review" box that appeared when the drop-down button is clicked on the [Review changes] button.
I'm slowly learning git by way of using it as I go. I believe this is my first time ever using the [Review changes] functionality in github, so my apologies if I'm not doing something right here.
All good, thanks for contributing! |
Fix broken link to vanitygen. (Proof that the page was 404: https://archive.ph/iY5oI)
This is an attempt to change the destination link...
FROM: https://bips.dev/15/vanitygen
TO: https://github.com/klynastor/supervanitygen
...using the syntax of Github Mediawiki format as mentioned here.