Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bip-0015.mediawiki #1611

Closed
wants to merge 1 commit into from
Closed

Conversation

GlenCooper
Copy link
Contributor

Fix broken link to vanitygen. (Proof that the page was 404: https://archive.ph/iY5oI)

This is an attempt to change the destination link...
FROM: https://bips.dev/15/vanitygen
TO: https://github.com/klynastor/supervanitygen
...using the syntax of Github Mediawiki format as mentioned here.

@@ -36,7 +36,7 @@ Their FirstBits alias becomes:

It is enough information to be given the FirstBits alias ''1brmlab''. When someone wishes to make a purchase, without FirstBits, they either have to type out their address laboriously by hand, scan their QR code (which requires a mobile handset that this author does not own) or find their address on the internet to copy and paste into the client to send bitcoins. FirstBits alleviates this impracticality by providing an easy method to make payments.

Together with [[vanitygen|Vanitygen (vanity generator)]], it becomes possible to create memorable unique named addresses. Addresses that are meaningful, rather than an odd assemblage of letters and numbers but add context to the destination.
Together with [vanitygen https://github.com/klynastor/supervanitygen], it becomes possible to create memorable unique named addresses. Addresses that are meaningful, rather than an odd assemblage of letters and numbers but add context to the destination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell from the commit history of this repository, this link was always broken. Rather than assigning it a destination that may or may not match the BIP Champion’s intention, it would be preferable to remove the link altogether.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be preferable to remove the link altogether.

Good point.
I have emailed the BIP Champion for his input and asked him to review this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have emailed the BIP Champion for his input and asked him to review this PR.

The email bounced. Now what?

image

bip-0015.mediawiki Show resolved Hide resolved
@murchandamus murchandamus added Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author labels Jun 10, 2024
@GlenCooper GlenCooper closed this Jun 11, 2024
@GlenCooper GlenCooper reopened this Jun 11, 2024
@GlenCooper
Copy link
Contributor Author

Agreed. Closing this PR and going with #1618 instead.

@GlenCooper GlenCooper closed this Jun 11, 2024
@GlenCooper GlenCooper deleted the patch-1 branch June 11, 2024 12:46
Copy link
Contributor Author

@GlenCooper GlenCooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm typing this in the "Finish your review" box that appeared when the drop-down button is clicked on the [Review changes] button.

I'm slowly learning git by way of using it as I go. I believe this is my first time ever using the [Review changes] functionality in github, so my apologies if I'm not doing something right here.

@murchandamus
Copy link
Contributor

All good, thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending acceptance This BIP modification requires sign-off by the champion of the BIP being modified PR Author action required Needs updates, has unaddressed review comments, or is otherwise waiting for PR author Proposed BIP modification
Projects
None yet
2 participants