bip-0062: add nLockTime exception case as an overflow of 4-byte int #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BIP 62 has been withdrawn. I’m not sure it makes sense to continue work on it. cc: @sipa |
|
NACK, this is changing the proposal. While it would be right to include this change is this were proposed today, that's not the case, because as @murchandamus points out it is withdrawn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP62 states number is strictly limited 4 byte int range, but it breaks forward compatibility with BIP65 as now. Add exception case of locktime number(which can be up to 2**32-1) to correct.