Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP329: Add optional key origin property and expand truncation note #1412

Merged
merged 2 commits into from
May 16, 2023

Conversation

craigraw
Copy link
Contributor

@craigraw craigraw commented Feb 3, 2023

Based on feedback received after BIP329 was initially published, this adds the following:

  • An optional origin property containing key origin information which can be used to to disambiguate labels from different wallets contained in the same export
  • A note on warning users if truncation is applied, along with a suggested maximum label length

@craigraw
Copy link
Contributor Author

craigraw commented Feb 7, 2023

On further consideration, the origin property has been changed to reflect an abbreviated output descriptor (including key origin information but excluding actual keys, child path elements or a checksum). This is necessary to handle multiple script types and more complex wallets including multisig wallets.

@kallewoof kallewoof merged commit 80d4474 into bitcoin:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants