-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when using "Time is day of week" filter #178
Comments
Original comment by |
Original comment by |
Another report on this one: I'm using CM12.1 nightly on a Galaxy Note 3. |
Thanks for the report! Could you post a logcat of the crash if you have one? |
Looking at the one above I'm guessing it's a bug with the filter not being properly inserted into the database |
I'm running into the same exception, only with different line numbers. (This is version 0.5.0 from F-Droid.) I'm running a recent Cyanogenmod 13 Nightly on a LG G3.
|
Yeah, this bugfix didn't make it into this release. I'll try to get it into the next one. |
I did some analysis on this one. As far as I can tell, |
I got one step further: After adding a value to The next step would be to replace the |
Got the UI working, but the data doesn’t get stored. Will keep investigating... |
Got it. The issue with the data getting stored was due to a bug I’d introduced in an earlier commit in my private branch. This is now fixed, and weekday rules now work in my branch. |
Signed-off-by: mvglasow <michael -at- vonglasow.com>
And the commit is: Still waiting for #218 to get merged, plus some of my features which introduce functionality needed for this fix (which is really an addition of a feature that has been half-implemented up to now). |
#218 is merged, but it turns out some other fixes (#222, #226 and possibly #225) became necessary—two for proper build environment support, one which fixes a bug with PowerOffAction not being inserted during a DB upgrade. Once they’re added, I can file a pull request for the fix. @biotinker I have a few things in the queue, several new features (events for WiFi and Bluetooth connect/disconnect, battery percentage change and GPS fix change; attribute for headset presence; action for speech output) as well as some UI changes (consistent use of default device theme). The fix (being really a completion of an incomplete feature) relies on code introduced with at least one of these features. Do you prefer one big pull request, or would you like me to break it down to one per feature? Also, during development I have bumped the DB version once for each new feature (six versions in total)—is that OK or would you like me to consolidate it to something like one new version per pull request? |
Original issue reported on code.google.com by
[email protected]
on 5 Mar 2012 at 5:03The text was updated successfully, but these errors were encountered: