Fix tests (#18) and mocking NCBI API #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to record http request response into fixtures files and later use those to mock the external API (NCBI) so that tests don't break all the time due to NCBI side changes rather than ours
9c1c852
to
9a38f26
Compare
IsmailM
reviewed
Apr 9, 2017
cli.js
Outdated
| @@ -46,8 +46,8 @@ if (command === 'link') { | |||
| var arg2 = argv._[2] | |||
| var arg3 = argv._[3] | |||
| } else { | |||
| var arg2 = argv._.slice(2).join(' ') | |||
| var arg3 = null | |||
| arg2 = argv._.slice(2).join(' ') | |||
There was a problem hiding this comment.
These variables aren't declared if command !== 'link'
There was a problem hiding this comment.
They are declared because JavaScript doesn't have block scope, only function scope, so they get hoisted. However, this might be confusing so I'll fix it. Thanks for noticing it!
IsmailM
approved these changes
Apr 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should no longer break often due to NCBI changes and we can once in a while update the mock data automatically to make sure our code is still relevant.