-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An error in the function 'get_one_hot' #14
Comments
renzph
added a commit
that referenced
this issue
Mar 29, 2024
1. Changes to `get_one_hot` Problems are given in: - #14 - #17 - #13 I discarded the changes in the PRs and and added more comprehensive handling of the input data in the `SmilesDataset` class and the `get_one_hot` function. 2. Imaginary components Frechet distance calculation fails to work for some cases because of badly conditioned matrices, as described here #15. Could not reproduce the error locally, but could do so on colab. Fixed it in `calculate_frechet_distance` by checking if the first `covmean` computation is real add a small value to the diagonal. This made it work for me and I got the same result as the original implementation run locally. 3. Added some more tests and changed to pytest 4. As described in #16 I changed the data type of the activations to float32 in the `get_predictions` function, which saves memory for larger datasets.
renzph
added a commit
that referenced
this issue
Apr 1, 2024
1. Changes to `get_one_hot` Problems are given in: - #14 - #17 - #13 I discarded the changes in the PRs and and added more comprehensive handling of the input data in the `SmilesDataset` class and the `get_one_hot` function. 2. Imaginary components Frechet distance calculation fails to work for some cases because of badly conditioned matrices, as described here #15. Could not reproduce the error locally, but could do so on colab. Fixed it in `calculate_frechet_distance` by checking if the first `covmean` computation is real add a small value to the diagonal. This made it work for me and I got the same result as the original implementation run locally. 3. Added some more tests and changed to pytest 4. As described in #16 I changed the data type of the activations to float32 in the `get_predictions` function, which saves memory for larger datasets.
renzph
added a commit
that referenced
this issue
Apr 1, 2024
1. Changes to `get_one_hot` Problems are given in: - #14 - #17 - #13 I discarded the changes in the PRs and and added more comprehensive handling of the input data in the `SmilesDataset` class and the `get_one_hot` function. 2. Imaginary components Frechet distance calculation fails to work for some cases because of badly conditioned matrices, as described here #15. Could not reproduce the error locally, but could do so on colab. Fixed it in `calculate_frechet_distance` by checking if the first `covmean` computation is real add a small value to the diagonal. This made it work for me and I got the same result as the original implementation run locally. 3. Added some more tests and changed to pytest 4. As described in #16 I changed the data type of the activations to float32 in the `get_predictions` function, which saves memory for larger datasets.
renzph
added a commit
that referenced
this issue
Apr 1, 2024
1. Changes to `get_one_hot` Problems are given in: - #14 - #17 - #13 I discarded the changes in the PRs and and added more comprehensive handling of the input data in the `SmilesDataset` class and the `get_one_hot` function. 2. Imaginary components Frechet distance calculation fails to work for some cases because of badly conditioned matrices, as described here #15. Could not reproduce the error locally, but could do so on colab. Fixed it in `calculate_frechet_distance` by checking if the first `covmean` computation is real add a small value to the diagonal. This made it work for me and I got the same result as the original implementation run locally. 3. Added some more tests and changed to pytest 4. As described in #16 I changed the data type of the activations to float32 in the `get_predictions` function, which saves memory for larger datasets.
renzph
added a commit
that referenced
this issue
Apr 1, 2024
1. Changes to `get_one_hot` Problems are given in: - #14 - #17 - #13 I discarded the changes in the PRs and and added more comprehensive handling of the input data in the `SmilesDataset` class and the `get_one_hot` function. 2. Imaginary components Frechet distance calculation fails to work for some cases because of badly conditioned matrices, as described here #15. Could not reproduce the error locally, but could do so on colab. Fixed it in `calculate_frechet_distance` by checking if the first `covmean` computation is real add a small value to the diagonal. This made it work for me and I got the same result as the original implementation run locally. 3. Added some more tests and changed to pytest 4. As described in #16 I changed the data type of the activations to float32 in the `get_predictions` function, which saves memory for larger datasets.
renzph
added a commit
that referenced
this issue
Apr 1, 2024
1. Changes to `get_one_hot` Problems are given in: - #14 - #17 - #13 I discarded the changes in the PRs and and added more comprehensive handling of the input data in the `SmilesDataset` class and the `get_one_hot` function. 2. Imaginary components Frechet distance calculation fails to work for some cases because of badly conditioned matrices, as described here #15. Could not reproduce the error locally, but could do so on colab. Fixed it in `calculate_frechet_distance` by checking if the first `covmean` computation is real add a small value to the diagonal. This made it work for me and I got the same result as the original implementation run locally. 3. Added some more tests and changed to pytest 4. As described in #16 I changed the data type of the activations to float32 in the `get_predictions` function, which saves memory for larger datasets. 5. Change to pyproject.toml
Thanks for your comment. This has been fixed in 1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when the getitem function is called, get_one_hot(smiles, 350) is called. In get_one_hot(smiles, 350) function, the array_length is limited within 350, but the index of numeric can exceed 350, causing the IndexError for one_hot in axis 0.
The text was updated successfully, but these errors were encountered: