Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Middle mouse close window (See e-mail) + Fix Issue #4 #3

Merged
merged 2 commits into from
Dec 22, 2011
Merged

Add: Middle mouse close window (See e-mail) + Fix Issue #4 #3

merged 2 commits into from
Dec 22, 2011

Conversation

FPtje
Copy link
Contributor

@FPtje FPtje commented Dec 21, 2011

Add: Middle mouse now closes a client in revelation mode
Fix: Clients losing their position and size when they were in a floating tag.

under the pointer.

This is very useful for window management. When you have many
windows open and you want to close some, you can just open
revelation and close the windows with middle mouse.

I have maintained your coding style, but I recommend not testing
boolean variables against true/false. So instead of
if mouse.buttons[1] == true then ...
you would have
if mouse.buttons[1] then

and instead of
if mouse.buttons[1] == false then -- doesn't actually appear in
code
you would have
if not mouse.buttons[1] then ...

That's just a minor niggle though.
bioe007 pushed a commit that referenced this pull request Dec 22, 2011
Middle mouse close window. Stores floating client geometry closes #4
@bioe007 bioe007 merged commit e0d9dd3 into bioe007:master Dec 22, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants