-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p type cannot be validated #727
Labels
bug
Something isn't working
Comments
markgene
added a commit
to markgene/hgvs
that referenced
this issue
Feb 7, 2024
I make the changes to fix the issue described at biocommons#727
This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
github-actions
bot
added
the
stale
Issue is stale and subject to automatic closing
label
May 8, 2024
jsstevenson
added
bug
Something isn't working
and removed
stale
Issue is stale and subject to automatic closing
labels
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I get an error message of
AttributeError: 'AARefAlt' object has no attribute 'ref_n'
when usingvalidate()
against a protein variant.To Reproduce
Steps to reproduce the behavior, invoke
hgvs-shell
(v1.5.4):It raised the error:
Expected behavior
I expect a boolean returned value.
Additional context
The traceback pointed the error to
posedit.py
:It seems we can solve the problem by adding
ref_n
to AARefAltdecorated by
@property`. I made a patch at here. It fixes the problem from my side, but am not sure if it fits well to the whole package. Thanks!The text was updated successfully, but these errors were encountered: