Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readme, fix version, add license to try script #40

Merged
merged 5 commits into from
Jun 24, 2023
Merged

Improve readme, fix version, add license to try script #40

merged 5 commits into from
Jun 24, 2023

Conversation

ezrizhu
Copy link
Collaborator

@ezrizhu ezrizhu commented Jun 23, 2023

Readme

  • Include rustup installer in the readme
  • Trim some output to make everything look more readable
  • Add the UID/GID issue in readme under "known issue"

Try

  • Using version 0.1.0 as specified in semantic versioning
  • Add -v to the getopts so -v gets registered
  • Move the version definition to the top of the file
  • Add license text and link to this repo

Closes #39

@ezrizhu ezrizhu requested a review from angelhof June 23, 2023 22:21
mgree
mgree approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@mgree mgree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

try
#
# https://github.com/binpash/try

ver="0.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's best to use all caps for important/non-local variables, e.g., TRY_VERSION.

@mgree mgree merged commit d557a0a into main Jun 24, 2023
@ezrizhu ezrizhu deleted the readme-and-version branch June 25, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgree mgree mgree approved these changes

@angelhof angelhof Awaiting requested review from angelhof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] version information is not displayed.
2 participants
@ezrizhu @mgree