Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI, as requested, I implemented the test required for crash that I am experiencing in my application.
Here is the demo for the crash in my application:
https://github.com/ppamorim/openraft/tree/bincode-bug/example-raft-kv
You will need to run
./test-cluster.sh
, wait it to finish and read the logn1.log
. The code that causes the crash is here: https://github.com/ppamorim/openraft/blob/bincode-bug/example-raft-kv/src/store/mod.rs#L230-L244The struct that causes the problem is here: https://github.com/datafuselabs/openraft/blob/main/openraft/src/membership/membership.rs#L21