Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make readonly bash variables explicitly readonly #2665

Closed
wants to merge 1 commit into from

Conversation

mtlynch
Copy link
Sponsor

@mtlynch mtlynch commented Jun 22, 2024

Description

In bash scripts, I noticed a few variables that are read-only, but they're not declared as readonly in bash. Declaring them as readonly protects against potential bugs in the future where code may unintentionally overwrite these variables.

I didn't apply readonly to the variable PACKAGE_VERSION because it is unused and I'm proposing its deletion in #2666

Corresponding issue: N/A

Testing

Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.

I ran the scripts manually.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@alexpetros
Copy link
Collaborator

Closing per contributions guides (this is not a bugfix, documentation update, or solicited new feature). These are small scripts, it's not that big a deal

@alexpetros alexpetros closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants