fix: Small cleanups from recent test fixes #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1992 +/- ##
==========================================
+ Coverage 85.68% 87.04% +1.36%
==========================================
Files 91 131 +40
Lines 3792 6306 +2514
Branches 1220 1520 +300
==========================================
+ Hits 3249 5489 +2240
- Misses 457 726 +269
- Partials 86 91 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was meaning to get these in before #1989 was merged, but nbd. I saw on https://deno.land/[email protected]/path/mod.ts?s=posix that
path.posixis deprecated. Also, the Windows fixes made me want to go back and clean up the changes I made for OSX. The use of an explicit/tmpseems like it's asking for trouble, and if we create a temporary directory, things simplify a bit.