Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an export for validateCommand to allow other tools to reuse the validator's argument parsing #1844

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

nellh
Copy link
Member

@nellh nellh commented Nov 13, 2023

Exporting validateCommand lets OpenNeuro provide the validator arguments for any commands that requires validation (upload) without needing to duplicate the command parsing.

@nellh nellh requested a review from rwblair November 13, 2023 00:48
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (596b9e9) 85.58% compared to head (127e8c3) 83.57%.
Report is 55 commits behind head on master.

❗ Current head 127e8c3 differs from pull request most recent head 20c36b1. Consider uploading reports for the commit 20c36b1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1844      +/-   ##
==========================================
- Coverage   85.58%   83.57%   -2.01%     
==========================================
  Files         131       92      -39     
  Lines        6638     3897    -2741     
  Branches     1537     1273     -264     
==========================================
- Hits         5681     3257    -2424     
+ Misses        849      542     -307     
+ Partials      108       98      -10     
Files Coverage Δ
bids-validator/validators/json/json.js 100.00% <100.00%> (ø)
bids-validator/validators/tsv/tsv.js 94.19% <ø> (ø)

... and 40 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwblair rwblair merged commit 580a07e into bids-standard:master Nov 13, 2023
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants