FIX: Failing expression tests #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1826 +/- ##
==========================================
- Coverage 85.49% 83.56% -1.93%
==========================================
Files 132 92 -40
Lines 6701 3895 -2806
Branches 1546 1272 -274
==========================================
- Hits 5729 3255 -2474
+ Misses 864 542 -322
+ Partials 108 98 -10 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
fix/expressions
branch
from
e629872
to
2d6288c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started testing expressions with functions, and fixed a couple up. There's a spec PR we need to get in with new expectations.