Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCHEMA: Add file rule for phenotype tables #1672

Merged
merged 7 commits into from
May 23, 2024

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Dec 17, 2023

This PR slightly amends how stem rules work, by making the stem a glob pattern and allowing it to coexist with datatype. This hacks 'phenotype' into the datatype structure; in the absence of entities, it works correctly for now.

I don't know that this is a long-term solution, but it seems good enough for now with minimal changes required to the schematools or the JS schema validator.

This is intended to be compatible with, but not actually dependent on #1693.

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Dec 17, 2023
Copy link

codecov bot commented Dec 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (0950f6d) to head (8454ebd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
+ Coverage   87.92%   88.04%   +0.11%     
==========================================
  Files          16       16              
  Lines        1375     1380       +5     
==========================================
+ Hits         1209     1215       +6     
+ Misses        166      165       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies

This comment was marked as outdated.

@effigies effigies closed this Feb 15, 2024
@effigies effigies reopened this Feb 16, 2024
@effigies effigies changed the title SCHEMA: Add file rule hack for phenotype tables SCHEMA: Add file rule for phenotype tables Feb 16, 2024
@effigies effigies force-pushed the schema/phenotype branch 3 times, most recently from c3c6696 to 1a056e7 Compare February 16, 2024 15:32
@effigies
Copy link
Collaborator Author

@rwblair @tsalo Let me know what you think.

effigies added a commit to bids-standard/bids-validator that referenced this pull request May 2, 2024
effigies added a commit to bids-standard/bids-validator that referenced this pull request May 2, 2024
effigies added a commit to bids-standard/bids-validator that referenced this pull request May 2, 2024
@effigies effigies merged commit 2246cd8 into bids-standard:master May 23, 2024
26 checks passed
@effigies effigies deleted the schema/phenotype branch May 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants