Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCHEMA] Improve check messages #1599

Merged
merged 4 commits into from
Aug 25, 2023
Merged

[SCHEMA] Improve check messages #1599

merged 4 commits into from
Aug 25, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 24, 2023

Closes None.

Changes proposed:

  • Improve messages for a number of checks.
  • Remove a redundant phase entity rule.
  • Add note about 89+ privacy recommendation to age column description.

@tsalo tsalo added the schema Issues related to the YAML schema representation of the specification. Patch version release. label Aug 24, 2023
Remi-Gau
Remi-Gau approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks @tsalo

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (02d97b0) 87.83% compared to head (ba32a3d) 87.83%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1599   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies added the exclude-from-changelog This item will not feature in the automatically generated changelog label Aug 24, 2023
@tsalo
Copy link
Member Author

tsalo commented Aug 25, 2023

I'm sure there'll be conflicts with #1600. @effigies which would you like to merge first?

@effigies
Copy link
Collaborator

Nope. Nobody's approved it. I'll merge this and see.

@effigies effigies merged commit 60c173d into bids-standard:master Aug 25, 2023
26 checks passed
@effigies effigies changed the title Improve check messages [SCHEMA] Improve check messages Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@Remi-Gau Remi-Gau Remi-Gau approved these changes

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsalo @effigies @Remi-Gau