chore: fix flutter 3 issues #13
Conversation
| @@ -403,7 +403,7 @@ class GlassContainer extends StatelessWidget { | |||
| current = ClipOval(child: current); | |||
| } else { | |||
| assert(borderRadius != null); | |||
| current = ClipRRect(borderRadius: borderRadius, child: current); | |||
| current = ClipRRect(borderRadius: borderRadius!, child: current); | |||
There was a problem hiding this comment.
let's use conditional/null-aware(??) operators instead of null-assertion(!)
There was a problem hiding this comment.
I did not want to remove the assertion and therefore a conditional operator was not necessary. As far as the assert should be removed, you can of course use the ?? BorderRadius.zero.
There was a problem hiding this comment.
any reason why the change in pubspec.lock was required? can it be done by changing the versions in pubspec.yaml
There was a problem hiding this comment.
That was my mistake for committing this. I have not changed any versions. The pubspec.lock was apparently just not synchronized with the pubspec.yaml.
|
@all-contributors please add @maeddin for maintenance and code |
|
I've put up a pull request to add @maeddin! 🎉 |
No description provided.