No system.drawing #158
Merged
No system.drawing #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The future of
System.Drawingnamespace seems unclear, this PR removes the reference to any object in this namespace, the library was only usingColor,SizeFandPointFstructs in this namespace, with this PR the library defines is own objects and removes the need to reference this namespace in the core packages.Breaking Changes
Sadly this is the first PR that has breaking changes, but the changes are minimal and might not apply for everyone using the library.
System.Drawing.Colornow should useLiveChartsCore.Drawing.LvcColor.System.Drawing.SizeFnow should useLiveChartsCore.Drawing.LvcSize.System.Drawing.PointFnow should useLiveChartsCore.Drawing.LvcPoint.