Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSP2_UBLOX_REQUEST_SV_INFO #3689

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Add MSP2_UBLOX_REQUEST_SV_INFO #3689

merged 3 commits into from
Dec 24, 2023

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 22, 2023 •
edited
Loading

See betaflight/betaflight#13240

Should fix configurator missing satellite data request more reliable.

  • Adds MSP2_UBLOX_REQUEST_SV_INFO request to activate SatInfo polling in firmware.
  • SatInfo will be turned off upon ARMING the quad.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Dec 22, 2023
@haslinghuis haslinghuis self-assigned this Dec 22, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis changed the title Add MSP2_GPS_REQUEST_SV_INFO Add MSP2_UBLOX_REQUEST_SV_INFO Dec 23, 2023
@haslinghuis haslinghuis mentioned this pull request Dec 23, 2023
Merged
@blckmn
Copy link
Member

blckmn commented Dec 23, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis modified the milestones: 10.10.0, 11.0 Dec 23, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 23, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis modified the milestones: 11.0, 10.10.0 Dec 24, 2023
@haslinghuis haslinghuis merged commit 9117326 into betaflight:master Dec 24, 2023
8 checks passed
@haslinghuis haslinghuis deleted the add-msp-satinfo-request branch December 24, 2023 23:50
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@haslinghuis @chmelevskij
Add MSP2_UBLOX_REQUEST_SV_INFO (betaflight#3689)
6b6adf2 
* Add MSP2_GPS_REQUEST_SV_INFO

* Rename MSP

* Add console message for request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haslinghuis @blckmn @McGiverGim @sugaarK