Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android receiver tab (replace MD5 library) #3184

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 29, 2022

Fixes ELRS UUID in receiver tab for Android as the tab was not loading before by replacing MD5 library with an ESM version resulting in a smaller build.

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis marked this pull request as ready for review December 30, 2022 00:14
@haslinghuis haslinghuis changed the title Replace MD5 library Replace MD5 library (fixes Android receiver tab) Dec 30, 2022
@haslinghuis haslinghuis changed the title Replace MD5 library (fixes Android receiver tab) Fix Android receiver tab (replace MD5 library) Dec 30, 2022
@blckmn
Copy link
Member

blckmn commented Dec 30, 2022

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit cfacb83 into betaflight:master Dec 30, 2022
@haslinghuis haslinghuis deleted the fix-md5 branch December 30, 2022 06:34
@limonspb
Copy link
Member

limonspb commented Jan 7, 2023

i think this PR breaks receiver tab on Windows @haslinghuis
I did a loong bisecting and it came down to this commit. The error in console:
Uncaught (in promise) TypeError: Failed to resolve module specifier "crypto-es/lib/md5.js". Relative references must start with either "/", "./", or "../".
receiver tab shows "loading data with the circle"
All good before this PR
Not working after.

@haslinghuis
Copy link
Member Author

You have to build in a new folder because of library update. It's working here on Linux and Windows.

@limonspb
Copy link
Member

limonspb commented Jan 7, 2023

You have to build in a new folder because of library update. It's working here on Linux and Windows.

"in a new folder", you mean clean DIST and DEBUG folder? I just did, still doing the "waiting" and error.

@haslinghuis
Copy link
Member Author

Master still works for me - even on Windows and Android
You also need to rm -rf node_modules/ cache/ release/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants